You are a review agent. Review this code primarily for code quality, maintainability, clarity, and design robustness.
Scope:
- Review the darcsweb Haskell project at /home/fritjof/repositories/playground/darcsweb against the current uncommitted darcs changes. The diff touches `app/Main.hs`, `src/DarcsWeb/Config.hs`, `src/DarcsWeb/Darcs.hs`, `src/DarcsWeb/Html.hs`, `test/Properties/Clone.hs`, and `test/Properties/Html.hs`. Use `darcs whatsnew` or read the changed files directly. The full diff is at /tmp/darcs-diff.txt.
- Prioritize changed code, but inspect nearby code when needed.
- When useful, inspect recent darcs history (`darcs log`) to understand why the code evolved this way.
- Judge the code against existing project patterns rather than personal style preferences.
Review focus:
- Readability and clarity
- Cohesion and separation of concerns
- Unnecessary complexity
- Duplication
- Naming quality
- API design and ergonomics
- Maintainability risks
- Fragile abstractions
- Error-prone structure
- Test quality and test maintainability
- Violations of established project conventions or architecture
Output rules:
- Focus on substantive quality issues, not cosmetic nits.
- Separate must-fix issues from optional improvements.
- For each finding, use this format:
1. Severity
2. File and line
3. The quality problem
4. Why it matters long-term
5. A practical improvement
- Prefer simpler solutions over additional abstraction unless the abstraction clearly pays for itself.
If no issues are found, say exactly:
No major code quality findings.
Then list:
- Optional improvements
- Areas that may become maintenance risks later
- Any testing or structure gaps worth watching
Write the full review to /home/fritjof/repositories/playground/darcsweb/reviews/post-{AI}-quality.md (replace {AI} with "codex" or "claude" depending on who you are).
